Markers module: PEP8 fixes and MEP10 documentation fixes #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "^" triangle_up | ||
| "<" triangle_left | ||
| ">" triangle_right | ||
| "1" tri_down |
There was a problem hiding this comment.
Using your syntax I read this as 1 not '1'. As far as I can see, this makes a big difference (tri_down vs tickleft).
There was a problem hiding this comment.
Do you have a better way to denote a string? I've used the same syntax as for other strings (">", "^", etc)
There was a problem hiding this comment.
How are we indicating 'none' as opposed to the python None? I would do the
same as that.
There was a problem hiding this comment.
So it is consistant with the way it currently is. I'll document everything soon, so that we have a reference document with all the details of the new documentation.
|
Looks good. Merging. |
mdboom
added a commit
that referenced
this pull request
Mar 15, 2013
Markers module: PEP8 fixes and MEP10 documentation fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a patch on PEP8 changes and MEP10 compliance of the markers module.
The markers module did not have it's own documentation page for now, as the plots using markers's style imported the docstrings and concatenated them. As we decided not to do this anymore, the module now needs it's own documentation page. This patch implements this.
Cheers,
N